fix: use Object.prototype.hasOwnProperty.call for null-prototype store objects#2793
Open
tsushanth wants to merge 1 commit into
Open
fix: use Object.prototype.hasOwnProperty.call for null-prototype store objects#2793tsushanth wants to merge 1 commit into
tsushanth wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: eb200e8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Null-prototype objects (created with
Object.create(null)) are commonly used as dictionary-style maps because they avoid inherited properties likeconstructorand__proto__. When a store proxy wraps such an object and a function-valued property is accessed, the proxy calls.hasOwnProperty()directly on the target. Because null-prototype objects do not inherit fromObject.prototype, this throwsTypeError: target.hasOwnProperty is not a function.This patch replaces the two direct
.hasOwnProperty()calls instore.tsandmutable.tswithObject.prototype.hasOwnProperty.call(target, property), which is safe regardless of the object's prototype chain.Fixes #2771